Review Request 125745: Energy module: Limit org.freedesktop.UPower.Wakeups.GetData calls to one per second

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125745/#review87226
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Oct. 21, 2015, 8:51 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125745/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 8:51 p.m.)
> 
> 
> Review request for KInfoCenter and Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> -------
> 
> It is possible that DataChanged is emitted very quickly, up to the point that upower won't be able to respond, resulting in errors due to maximum number of pending replies.
> One update per second should be enough.
> 
> 
> Diffs
> -----
> 
>   Modules/energy/wakeupmodel.h ce0809b 
>   Modules/energy/wakeupmodel.cpp 372ae2d 
> 
> Diff: https://git.reviewboard.kde.org/r/125745/diff/
> 
> 
> Testing
> -------
> 
> On Debian with upower (0.99.3-1+b2), after opening energy module upower would quickly start to use 100% cpu. This patch fixes it and makes the history graph appear, but there are still some other issues...
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151021/c3012dda/attachment.html>