Review Request 125734: Fix crash when exiting kscreen kcm in systemsettings

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125734/
-----------------------------------------------------------

(Updated Oct. 21, 2015, 2:54 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Kai Uwe Broulik and Daniel Vrátil.


Changes
-------

Submitted with commit 4653c287f844f2cb19379ff001ca76d7d9e3a2a1 by Martin Gräßlin to branch Plasma/5.4.


Bugs: 344651
    http://bugs.kde.org/show_bug.cgi?id=344651


Repository: kscreen


Description
-------

When using threaded rendering loop [1] systemsettings crashed when
clicking the back button. This crash is caused inside the shader effect
used by the OpacityMask.
QtQuick informed us also that something is wrong:
"QSGDefaultLayer::bind: ShaderEffectSource: 'recursive' must be set to true when rendering recursively."

The actual problem is that orientationPanelContainer and the OpacityMask
are children to the monitor item causing recursion. By making them
siblings to the orientationPanelContainer the problem is resolved. The
error message from QtQuick is no longer shown and systemsettings doesn't
crash any more.

BUG: 344651
FIXED-IN: 5.4.3

[1] QSG_RENDER_LOOP=threaded systemsettings5


Diffs
-----

  kcm/qml/Output.qml 7bcaf39174a748a203eab5a420cb57c3639d0024 

Diff: https://git.reviewboard.kde.org/r/125734/diff/


Testing
-------


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151021/7b458553/attachment.html>