Review Request 125705: Use LANG for month names in calendar applet

[Xuetian Weng]

> On Oct. 20, 2015, 9:30 p.m., Albert Astals Cid wrote:
> > src/declarativeimports/calendar/calendar.cpp, line 197
> > <https://git.reviewboard.kde.org/r/125705/diff/2/?file=411943#file411943line197>
> >
> >     uilanguages is not good for direct inputing into QLocale (yes i know, it's stupid).
> >     
> >     See how uilanguages returns en-US and QLocale wants en_US

Actually QLocale has no problem parsing things like en-US. See implementation https://github.com/qtproject/qtbase/blob/dev/src/corelib/tools/qlocale.cpp#L401 , the separator contains both _ and -. 

uiLanguages() tend to return standard bcp 47 format, thus I don't think the implementation will become stricter.


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125705/#review87164
-----------------------------------------------------------


On Oct. 20, 2015, 7:04 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125705/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 7:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 353715
>     http://bugs.kde.org/show_bug.cgi?id=353715
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Simple QDate::longMonthName won't do the job as it
> will return the month name using LC_DATE locale which is used
> for date formatting etc. So for example, in en_US locale
> and cs_CZ LC_DATE, it would return Czech month names while
> it should return English ones. So here we force the LANG
> locale and take the month name from that.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/calendar/calendar.cpp 67a08e5 
> 
> Diff: https://git.reviewboard.kde.org/r/125705/diff/
> 
> 
> Testing
> -------
> 
> LC_DATE=cs_CZ
> LANG=en_US
> 
> Month names in calendar applet are now english.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151020/5f1f0efe/attachment.html>