Review Request 125709: Ensure correct timezone is displayed when the selected ones change

Martin Klapetek martin.klapetek at gmail.com
Tue Oct 20 18:57:59 UTC 2015



> On Oct. 19, 2015, 8:02 p.m., David Edmundson wrote:
> > can it be merged with the code in main.qml which is already binding the connectedSources to plasmoid.configuration.selectedTimeZones ?
> > 
> > (this is the bit I meant last comment, I just got confused and pointed at the wrong part)

I found a better way, the connectedSources can be binded directly, I'm not sure why is it checking for empty stuff in the first place, but I think a) it's not a problem b) the dataengine should be able to handle that


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125709/#review87094
-----------------------------------------------------------


On Oct. 19, 2015, 7:54 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125709/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 7:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 353996
>     https://bugs.kde.org/show_bug.cgi?id=353996
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> When the user selects another timezone and deselects the current one,
> the clock timezone should change immediately.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml c644bfe 
> 
> Diff: https://git.reviewboard.kde.org/r/125709/diff/
> 
> 
> Testing
> -------
> 
> * Select UTC+14:00 timezone
> * Deselect Local timezone
> * Press Apply
> * Panel clock now has UTC+14:00 timezeon
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151020/f2a0aafb/attachment.html>


More information about the Plasma-devel mailing list