Review Request 125700: Drop remaning code for ShowDashboard
Martin Gräßlin
mgraesslin at kde.org
Tue Oct 20 05:52:00 UTC 2015
> On Oct. 19, 2015, 3:41 p.m., Martin Gräßlin wrote:
> > This also needs a kconf update, but I fear my scripting capabilities are not sufficient for that. It should be doable with a simple sed call, though.
>
> Thomas Lübking wrote:
> Humm? Looks like it's resolved to "None", what's good - isn't?
>
>
> +1
I was rather thinking we should migrate it to ShowDesktop.
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125700/#review87072
-----------------------------------------------------------
On Oct. 19, 2015, 3:41 p.m., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125700/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 3:41 p.m.)
>
>
> Review request for kwin and Plasma.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> Removes the ElectricAction for ShowDashboard and the relevant code
> in screenedges and the KCM.
>
> Also a leftover in the glide effect.
>
>
> Diffs
> -----
>
> effects/glide/glide.cpp 7f690a43afe60bfc1c75f6f6cf15fe81e31ab1b6
> kcmkwin/kwincompositing/kcmkwineffects.desktop ddcb5069e9dbe54d970f30eadea417bf142a594f
> kcmkwin/kwinscreenedges/main.cpp 997e87bb8676310f7326dc6c36b7c6568c098fa4
> libkwineffects/kwinglobals.h 92f6bf11b463c8dda3377a92c789ae48a46e6bd7
> screenedge.cpp 53e0478456755155c85dc755354ac31981cea466
>
> Diff: https://git.reviewboard.kde.org/r/125700/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Gräßlin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151020/bac413e6/attachment-0001.html>
More information about the Plasma-devel
mailing list