Review Request 125706: Install kconf_update script in kdelibs4 directory
Jonathan Riddell
jr at jriddell.org
Mon Oct 19 21:16:07 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125706/
-----------------------------------------------------------
(Updated Oct. 19, 2015, 9:16 p.m.)
Review request for Plasma, David Edmundson and Harald Sitter.
Changes
-------
install twice for kmix builds on kdelibs4 and kf5
Repository: plasma-pa
Description
-------
Install kconf_update script in kdelibs4 directory because kmix is a kdelibs4 application and installing it in kf5 directories won't do anything
This uses kde4-config. I looked at using KDELibs4 cmake classes from KDELibs4/KDELibsDependencies.cmake but couldn't work out how to load it in cmake and it has the wrong values set for its variables anyway.
Diffs (updated)
-----
data/CMakeLists.txt b652a0f
Diff: https://git.reviewboard.kde.org/r/125706/diff/
Testing
-------
Installs to the right place
When installed it writes the new kmixrc that turns off autostart
Thanks,
Jonathan Riddell
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151019/15b4aade/attachment.html>
More information about the Plasma-devel
mailing list