Review Request 125709: Ensure correct timezone is displayed when the selected ones change

Martin Klapetek martin.klapetek at gmail.com
Mon Oct 19 17:51:59 UTC 2015



> On Oct. 19, 2015, 7:47 p.m., David Edmundson wrote:
> > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 638
> > <https://git.reviewboard.kde.org/r/125709/diff/1/?file=411755#file411755line638>
> >
> >     do you need this still?

Yeah, in fact this should be a function and should be called from the connection too. This is to ensure continuous looping when you mouse scroll over the clock


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125709/#review87092
-----------------------------------------------------------


On Oct. 19, 2015, 7:40 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125709/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2015, 7:40 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 353996
>     https://bugs.kde.org/show_bug.cgi?id=353996
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> When the user selects another timezone and deselects the current one,
> the clock timezone should change immediately.
> 
> 
> Diffs
> -----
> 
>   applets/digital-clock/package/contents/ui/DigitalClock.qml c644bfe 
> 
> Diff: https://git.reviewboard.kde.org/r/125709/diff/
> 
> 
> Testing
> -------
> 
> * Select UTC+14:00 timezone
> * Deselect Local timezone
> * Press Apply
> * Panel clock now has UTC+14:00 timezeon
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151019/694a6ed8/attachment.html>


More information about the Plasma-devel mailing list