Review Request 125693: Prevent changing the primary screen when it doesn't have a view yet

[David Kahles]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125693/
-----------------------------------------------------------

(Updated Oct. 19, 2015, 11:10 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit 61828df89f3e7319bdc7024409804b51c0ba5b68 by David Kahles to branch master.


Repository: plasma-workspace


Description
-------

When a new primary output gets connected, it's possible that
primaryOutputChanged() is called before addOutput(). When addOutput()
was called afterwards, this led to two DesktopViews on the same
screen. This raised an assert in screenInvariants().
Solve this by not doing anything in primaryOutputChanged() when the new
primary output is not used for a DesktopView yet.


Diffs
-----

  shell/shellcorona.cpp 9185fb58a5e7ca09f916bbc5a231e7220a562c85 

Diff: https://git.reviewboard.kde.org/r/125693/diff/


Testing
-------

Plasmashell doesn't hit an assert in screenInvariants() after addOutput() when connecting a new screen set as primary screen.
(That doesn't mean it works, but at least there's a bug less)


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151019/8941af38/attachment.html>