Review Request 125693: Prevent changing the primary screen when it doesn't have a view yet

David Kahles david.kahles96 at gmail.com
Sun Oct 18 22:44:39 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125693/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-workspace


Description
-------

When a new primary output gets connected, it's possible that
primaryOutputChanged() is called before addOutput(). When addOutput()
was called afterwards, this led to two DesktopViews on the same
screen. This raised an assert in screenInvariants().
Solve this by not doing anything in primaryOutputChanged() when the new
primary output is not used for a DesktopView yet.


Diffs
-----

  shell/shellcorona.cpp 9185fb58a5e7ca09f916bbc5a231e7220a562c85 

Diff: https://git.reviewboard.kde.org/r/125693/diff/


Testing
-------

Plasmashell doesn't hit an assert in screenInvariants() after addOutput() when connecting a new screen set as primary screen.
(That doesn't mean it works, but at least there's a bug less)


Thanks,

David Kahles

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151018/980d63f4/attachment.html>


More information about the Plasma-devel mailing list