Review Request 125669: Remove redundant code

David Edmundson david at davidedmundson.co.uk
Sat Oct 17 09:51:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125669/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-workspace


Description
-------

We have a

connect(KWindowSystem::self(), &KWindowSystem::showingDesktopChanged,
[dashboardAction](bool showing) {
        dashboardAction->setText(showing ? i18n("Hide Dashboard") :
i18n("Show Dashboard"));

in the class constructor. Changing when we're invoked manually is pointless.


Diffs
-----

  shell/shellcorona.cpp b52a7a13b49be184915b1cb350d2e81fe4dffeac 

Diff: https://git.reviewboard.kde.org/r/125669/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151017/d9369057/attachment.html>


More information about the Plasma-devel mailing list