Review Request 125666: Add Spectacle to KHotkeys, disable the existing printscreen.khotkeys file

[Boudhayan Gupta]

> On Oct. 17, 2015, 1:39 p.m., David Edmundson wrote:
> > apps and plasma don't release at the same time, which means there's going to be a point in time where this is broken?
> 
> Boudhayan Gupta wrote:
>     Exactly why I posted an RR instead of directly committing the patch.
> 
> David Edmundson wrote:
>     a solution:
>     don't disable printscreen here, add a kconf update script in spectacle to disable ksnapshot
>     
>     plasma supports both, 
>     
>     if spectacle gets installed it disables ksnapshot itself. If spectacle is not installed we'll execute both but one will silently (I hope!) fail.

I'm making spectacle itself install the khotkeys rc file. I'll look at using kconf updates to disable ksnapshot.


- Boudhayan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125666/#review86940
-----------------------------------------------------------


On Oct. 17, 2015, 2:30 p.m., Boudhayan Gupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125666/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2015, 2:30 p.m.)
> 
> 
> Review request for Plasma, Martin Gräßlin and Jeremy Whiting.
> 
> 
> Repository: khotkeys
> 
> 
> Description
> -------
> 
> * Add a config file for launching Spectacle when PrintScreen is pressed (there are 3 shortcuts).
> * Disable the existing printscreen shortcut.
> 
> 
> Diffs
> -----
> 
>   data/printscreen.khotkeys bffe62e 
>   data/spectacle.khotkeys PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125666/diff/
> 
> 
> Testing
> -------
> 
> The correct actions are triggered when the keys are pressed.
> 
> 
> Thanks,
> 
> Boudhayan Gupta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151017/eb29fe54/attachment-0001.html>