Review Request 125657: Theme breeze icons from system theme when loaded trough IconItem

[Marco Martin]

> On Oct. 16, 2015, 1:19 p.m., David Edmundson wrote:
> > src/declarativeimports/core/iconitem.cpp, lines 341-348
> > <https://git.reviewboard.kde.org/r/125657/diff/1/?file=411309#file411309line341>
> >
> >     it looks like you already do all this on line 142 of this diff.

yeah, this is due the peculiarity of icon themes, since they can have different images on different sizes (that happens on svgs too, breeze does this a lot) so I may have to reload the svg when it gets resized


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125657/#review86916
-----------------------------------------------------------


On Oct. 16, 2015, 1:26 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125657/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 1:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This makes IconItem try to load global icons from the theme with Plasma::Svg as well, making it assign the colors from the stylesheet if the breeze monochrome icons are treated, that should be scriptable, from some attempts i did the script seems to convert them correctly, without any change in rendering.
> 
> This will automatically color monochrome breeze icons only in plasmashell, and more specifically only those that use IconItem, not QIconItem (iconitem should probably have an animation-less mode to be able to be used in taskmanager and stuff)
> perhaps in the future we'll be able somehow to hook all this stuff in QIconEngine to be able to use it in QWidget applications, but since QIcon does have any idea where it is, is not usable yet for things like the fullscreen fixed-dark gwenview view.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/core/iconitem.h 3ef0306 
>   src/declarativeimports/core/iconitem.cpp 692cd8d 
>   src/plasma/private/svg_p.h ab91c42 
>   src/plasma/svg.h 3ad21ce 
>   src/plasma/svg.cpp 37ced22 
> 
> Diff: https://git.reviewboard.kde.org/r/125657/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151016/c90ba1eb/attachment-0001.html>