Review Request 125655: Xembed SNI Proxy

[David Edmundson]

> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote:
> > xembedsniproxy/sniproxy.h, lines 42-50
> > <https://git.reviewboard.kde.org/r/125655/diff/1/?file=411303#file411303line42>
> >
> >     hmm?

ah right, I need some advice on here. 

There are properties that exist in the SNI spec that I can't do anything with. 
Should I return blank values, or return DBus errors?

Currently I do the latter.
Our plasma dataengine handles that fine, but I'm not sure which is more semantically correct.


> On Oct. 16, 2015, 12:34 p.m., Martin Gräßlin wrote:
> > xembedsniproxy/CMakeLists.txt, line 50
> > <https://git.reviewboard.kde.org/r/125655/diff/1/?file=411294#file411294line50>
> >
> >     are you sure you want -Wall. The last project I tried to build with that flag was unbuildable.
> >     
> >     I'm mostly concerned that this causes problems when compilers start to add more warnings and perfectly no-warning code starts to fail to build for other devs.

That's just turns on warnings, I think you're thinking of that "treat all warnings as fatal" flag.

but anyway see CMake comment in description, I'll strip this before merging.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/#review86912
-----------------------------------------------------------


On Oct. 16, 2015, 11:22 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125655/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2015, 11:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The goal of this project is to make xembed system trays available in Plasma.
> 
> This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] available in Plasma which only supports StatusNotifierItem [2].
> 
> Ideally we also want this to work in an xwayland session, making X system tray icons available even when plasmashell only has a wayland connection.
> 
> How it works (in theory)
> 
> * We register a window as a system tray container
> * We render embeded windows composited offscreen
> * We render contents into an image and send this over DBus via the SNI protocol
> * XDamage events trigger a repaint
> * Activate and context menu events are replyed via X send event into the embedded container as left and right clicks
> 
> 
> Code is a mix of hacks and bodges bashing client apps into place, and I happily acknowledge it looks pretty bad. Unfotunately most of it seems to be needed, but I'd love to be proved wrong on most of it.
> 
> ---
> 
> CMakeLists changes are obviously currently wrong, I can strip half of find_packages and I need an add_subdirectory in the root file, but it's easier for me to sync with the separate repo mirror this way till we're close to merging. I expect this to take quite some revisions.
> 
> 
> Diffs
> -----
> 
>   xembedsniproxy/CMakeLists.txt PRE-CREATION 
>   xembedsniproxy/Readme.md PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
>   xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
>   xembedsniproxy/main.cpp PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
>   xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
>   xembedsniproxy/snidbus.h PRE-CREATION 
>   xembedsniproxy/snidbus.cpp PRE-CREATION 
>   xembedsniproxy/sniproxy.h PRE-CREATION 
>   xembedsniproxy/sniproxy.cpp PRE-CREATION 
>   xembedsniproxy/xcbutils.h PRE-CREATION 
>   xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125655/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151016/2da20b49/attachment.html>