Review Request 125637: Don't assume dbus-launch autolaunch is still broken

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125637/#review86846
-----------------------------------------------------------


+1

- Aleix Pol Gonzalez


On Oct. 14, 2015, 5:01 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125637/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2015, 5:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> 1) it's not broken, that comment is ancient
> 
> 2) the test is bust. DBus path can also be stored as an x property.
> 
> Before this patch the situation is worse as potentially we risk
> launching two dbus daemons for the same session.
> 
> BUG: 352251
> 
> 
> Diffs
> -----
> 
>   startkde/startkde.cmake 17be28b7d13d4d18d332baf5700fe234ef103b6c 
>   startkde/startplasmacompositor.cmake d8ed68e58bb30bb69197f383a2e0eb9136d94b94 
> 
> Diff: https://git.reviewboard.kde.org/r/125637/diff/
> 
> 
> Testing
> -------
> 
> See last comment in bug.
> 
> The part regarding the env var is true. If it's autolaunched, there's no way that the application could write into the env of the parent process.
> I tested that connecting to dbus with a valid $DISPLAY but no DBUS_SESSION_BUS_ADDRESS and that works.
> 
> Change shouldn't affect anyone as all proper DMs will spawn dbus properly anyway. If that wasn't working we'd see more bug reports about ksplash locking - as we adjusted that to use dbus without reordering startkde.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151014/46a792df/attachment.html>