Review Request 125626: New activity switcher UI

[Ivan Čukić]

> On Oct. 13, 2015, 6:49 p.m., Thomas Pfeiffer wrote:
> > Great improvement overall!
> > Two things:
> > 1. The semantic of the button for stoping an Activity (close) does not correspond with "stop". Either they should be renamed to "Closed", or the icon should be changed to the one for stopping playback.
> > 2. Why is the button for creating a new Activity so far away from the list of Activities? I'd place it right below the list of running Activities so users won't miss it.
> 
> Ivan Čukić wrote:
>     1. If I get the icon for this, I'll use it (I don't think that the current stop icon in breeze would be suitable for this - a simple rectangle...). The 'delete' is also quite problematic.
>     2. It is in the same place it used to be in. It will probably changed in the near future.
> 
> andreas kainz wrote:
>     hi so you use 16px action icons. standard icon size is 22px and there you have an circle and an play Symbol
>     but I am also not 100%  happy with the 16px icons. my suggestion would be to use the 22px icons.

Larger ones are not much better - a filled square inside a line circle which is inside a line square (button). :) I'm abusing process-stop - will post a new screenshot along the new patch soon.


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125626/#review86819
-----------------------------------------------------------


On Oct. 13, 2015, 5:32 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125626/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 5:32 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is based on the VDG (Andrew's) mockup.
> 
> - Activities have more contextual information
> - Configuration and activity creation interface is the same as in activities KCM
> - Fixed the issue of plasma locking when Qt decides will-I-wount-I (the relayout loop when it decides whether to show a scroll-bar or not)
> 
> It requires the latest KActivities master.
> 
> 
> ![Shoot](http://ibin.co/2IvS4TSHzgKE)
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/activitymanager/ActivityDeletionDialog.qml 523aba6 
>   desktoppackage/contents/activitymanager/ActivityCreationDialog.qml 9317b0e 
>   desktoppackage/contents/activitymanager/ActivityItem.qml 526716c 
>   desktoppackage/contents/activitymanager/ActivityList.qml e8bf5f0 
>   desktoppackage/contents/activitymanager/ActivityManager.qml ff5cdc1 
>   desktoppackage/contents/activitymanager/ControlButton.qml 1e9854f 
>   desktoppackage/contents/activitymanager/Heading.qml be95b9e 
>   desktoppackage/contents/activitymanager/StoppedActivityItem.qml c1a417f 
>   desktoppackage/contents/activitymanager/static.js 0eaab96 
>   imports/activitymanager/switcherbackend.h 846862e 
>   imports/activitymanager/switcherbackend.cpp 736fe67 
> 
> Diff: https://git.reviewboard.kde.org/r/125626/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151013/57663fff/attachment.html>