Review Request 125626: New activity switcher UI

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125626/#review86815
-----------------------------------------------------------



desktoppackage/contents/activitymanager/ActivityItem.qml (line 163)
<https://git.reviewboard.kde.org/r/125626/#comment59713>

    This will do nothing
    
    you've aligned vertically but not set a bottom anchor. Therefore height will be the height of the text and no bigger



desktoppackage/contents/activitymanager/ActivityItem.qml (line 239)
<https://git.reviewboard.kde.org/r/125626/#comment59714>

    Leftover debug?



desktoppackage/contents/activitymanager/StoppedActivityItem.qml (line 45)
<https://git.reviewboard.kde.org/r/125626/#comment59712>

    what's this +4 for?



imports/activitymanager/switcherbackend.cpp (line 332)
<https://git.reviewboard.kde.org/r/125626/#comment59710>

    I think this whole thing with the callback and the recursion and now this extra guard are lot more complex than they need to be.
    
    Now we've got that guard to stop that infinite recursion bug if we can't save and it's growing to be a bit of a monster.
    
    Registering a a QQuickImageProvider with
    ForceAsynchronousImageLoading (so you can just exec() in the main method without blocking) will probably be both simpler code and more robust
    
    (also given KPreviewJob has a built in image cache, I think there's a possibility we're caching a cache here though I've not checked that properly)



imports/activitymanager/switcherbackend.cpp (line 418)
<https://git.reviewboard.kde.org/r/125626/#comment59709>

    see formatDecimalDuration
    in kcoreaddons


- David Edmundson


On Oct. 13, 2015, 5:32 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125626/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 5:32 p.m.)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This is based on the VDG (Andrew's) mockup.
> 
> - Activities have more contextual information
> - Configuration and activity creation interface is the same as in activities KCM
> - Fixed the issue of plasma locking when Qt decides will-I-wount-I (the relayout loop when it decides whether to show a scroll-bar or not)
> 
> It requires the latest KActivities master.
> 
> 
> ![Shoot](http://ibin.co/2IvS4TSHzgKE)
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/activitymanager/ActivityDeletionDialog.qml 523aba6 
>   desktoppackage/contents/activitymanager/ActivityCreationDialog.qml 9317b0e 
>   desktoppackage/contents/activitymanager/ActivityItem.qml 526716c 
>   desktoppackage/contents/activitymanager/ActivityList.qml e8bf5f0 
>   desktoppackage/contents/activitymanager/ActivityManager.qml ff5cdc1 
>   desktoppackage/contents/activitymanager/ControlButton.qml 1e9854f 
>   desktoppackage/contents/activitymanager/Heading.qml be95b9e 
>   desktoppackage/contents/activitymanager/StoppedActivityItem.qml c1a417f 
>   desktoppackage/contents/activitymanager/static.js 0eaab96 
>   imports/activitymanager/switcherbackend.h 846862e 
>   imports/activitymanager/switcherbackend.cpp 736fe67 
> 
> Diff: https://git.reviewboard.kde.org/r/125626/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151013/dae61c8d/attachment-0001.html>