Review Request 125014: Rotate wallpaper based on image EXIF

[Aleix Pol Gonzalez]

> On Oct. 13, 2015, 4:32 p.m., Marco Martin wrote:
> > All for it even tough i think i would prefer having the version bump associated to using new C++ api as well, so that we are sure on 5.4 it wouldn't build, not silently fail
> 
> Marco Martin wrote:
>     but even with just the cmake check is hopefully enough

What do you mean? you want to force usage of 5.5?

Anyway, we're already checking that: QT_VERSION_CHECK(5, 5, 0)


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125014/#review86809
-----------------------------------------------------------


On Oct. 13, 2015, 4:28 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125014/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2015, 4:28 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 352022
>     https://bugs.kde.org/show_bug.cgi?id=352022
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This requires bumping the version to Qt5.5 to use the new API
> 
> BUG: 352022
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4fdcf1a82feae406d6d216dc7bb662b0622f1fff 
>   wallpapers/image/imagepackage/contents/ui/main.qml 16ba43d9b57d69ee6f5a0c4d93209a4a0f125dd5 
> 
> Diff: https://git.reviewboard.kde.org/r/125014/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151013/f8879020/attachment.html>