Review Request 125088: Allow to change volume with mouse wheel in kcm

[David Rosca]

> On Oct. 12, 2015, 11:08 p.m., David Edmundson wrote:
> > applet/contents/ui/ListItemBase.qml, line 203
> > <https://git.reviewboard.kde.org/r/125088/diff/2/?file=410692#file410692line203>
> >
> >     why don't we have all the PendingWheelEvent stuff here?

Because in applet the wheel scrolling on sliders is disabled, see first review comment.


> On Oct. 12, 2015, 11:08 p.m., David Edmundson wrote:
> > src/kcm/package/contents/ui/VolumeSlider.qml, line 86
> > <https://git.reviewboard.kde.org/r/125088/diff/2/?file=410693#file410693line86>
> >
> >     I don't understand what this line is doing
> >     
> >     if we do block wheel events changing the slider's value, how will PulseObject.volume change?
> 
> David Kahles wrote:
>     It doesn't change the volume. This is a try to implement what I wrote as a comment above, so it tries to block the wheel events.
>     But I think this doesn't work as expected because the wheel events don't get passed to the list. So the volume doesn't change once a slider gets focus but nevertheless the scrolling is interrupted.
>     The only way I see (maybe there's a better way, don't know..) is the qt patch https://codereview.qt-project.org/#/c/124669/.

If we accept the wheel event here, it won't get propagated to the Slider and won't change the value (basically block the wheel event, as is done in applet - first issue).
The MouseArea is used only to get notified when the wheel event occurs (it is not accepted, so it will get to Slider and change the value accordingly) and then apply the changed value in onValueChanged.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125088/#review86769
-----------------------------------------------------------


On Oct. 12, 2015, 5:06 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125088/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 5:06 p.m.)
> 
> 
> Review request for Plasma and Harald Sitter.
> 
> 
> Repository: plasma-pa
> 
> 
> Description
> -------
> 
> Implement changing volume on mouse wheel.
> Also block wheel events on sliders in applet.
> 
> Without this patch, the value of slider gets changed but it won't change the actual volume.
> 
> 
> Diffs
> -----
> 
>   applet/contents/ui/ListItemBase.qml 8993b16 
>   src/kcm/package/contents/ui/VolumeSlider.qml c36dd33 
> 
> Diff: https://git.reviewboard.kde.org/r/125088/diff/
> 
> 
> Testing
> -------
> 
> Changing volume with wheel works in kcm. Trying to use wheel on sliders in applet does nothing.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151013/7617993a/attachment.html>