Review Request 125088: Allow to change volume with mouse wheel in kcm

David Rosca nowrep at gmail.com
Mon Oct 12 17:06:24 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125088/
-----------------------------------------------------------

(Updated Oct. 12, 2015, 5:06 p.m.)


Review request for Plasma and Harald Sitter.


Changes
-------

Block wheel events on sliders in applet


Summary (updated)
-----------------

Allow to change volume with mouse wheel in kcm


Repository: plasma-pa


Description (updated)
-------

Implement changing volume on mouse wheel.
Also block wheel events on sliders in applet.

Without this patch, the value of slider gets changed but it won't change the actual volume.


Diffs (updated)
-----

  applet/contents/ui/ListItemBase.qml 8993b16 
  src/kcm/package/contents/ui/VolumeSlider.qml c36dd33 

Diff: https://git.reviewboard.kde.org/r/125088/diff/


Testing (updated)
-------

Changing volume with wheel works in kcm. Trying to use wheel on sliders in applet does nothing.


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151012/301c2f34/attachment.html>


More information about the Plasma-devel mailing list