Review Request 125610: use org.kde.kuiserver5 dbus service (instead of org.kde.kuiserver)
Marco Martin
notmart at gmail.com
Mon Oct 12 17:00:48 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125610/#review86731
-----------------------------------------------------------
the notification plasmoid used to correctly display job info for both KDE4 and KF5 applications.
Did you check if this still works?
- Marco Martin
On Oct. 12, 2015, 4:53 p.m., Rex Dieter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125610/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 4:53 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 351500
> https://bugs.kde.org/show_bug.cgi?id=351500
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Exclusively use org.kde.kuiserver5 dbus service so it doesn't conflict with kde4's org.kde.kuiserver from kde-runtime
>
>
> Diffs
> -----
>
> dataengines/applicationjobs/kuiserverengine.cpp 93ef2d6
> kuiserver/CMakeLists.txt 0f7c29e
> kuiserver/org.kde.kuiserver.service.in 7a86d07
> kuiserver/org.kde.kuiserver.xml 7d465bc
> kuiserver/org.kde.kuiserver5.service.in PRE-CREATION
> kuiserver/org.kde.kuiserver5.xml PRE-CREATION
> kuiserver/progresslistmodel.h 490a683
> kuiserver/progresslistmodel.cpp fe147f3
>
> Diff: https://git.reviewboard.kde.org/r/125610/diff/
>
>
> Testing
> -------
>
> Applied patch, confirmed kuiserver builds, and plasma still functions as expected (it runs on plasma session login). Admittedly, I'm not privy to kuiserver's detailed purpose, so wasn't sure how to test it specifically.
>
>
> Thanks,
>
> Rex Dieter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151012/d0b25353/attachment-0001.html>
More information about the Plasma-devel
mailing list