Review Request 125605: Resize lock screen windows if screen size changes

[David Edmundson]

> On Oct. 12, 2015, 12:26 p.m., Martin Gräßlin wrote:
> > ksmserver/screenlocker/greeter/greeterapp.cpp, line 259
> > <https://git.reviewboard.kde.org/r/125605/diff/1/?file=410651#file410651line259>
> >
> >     can we trust that QScreen or should we use the one of the view?
> 
> Martin Gräßlin wrote:
>     in addition: should we connect to QWindow::screenChanged to handle screen removed and resized conditions?

we can't trust the screen from the view as it hasn't been set yet.
It defaults to primaryScreen() till you position the window on a screen

So currently this is more correct.
However, we can set a default screen when you create the view. That might be neater and save a few cycles.

RE: "in addition"
We already have have code handling screenAdded/removed.
There's no point reacting to screenChanged, as we'll remove the view just after.


(off topic, screenRemoved is using a workaround because we were missing a signal in Qt5.3 we can do that properly now)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125605/#review86708
-----------------------------------------------------------


On Oct. 12, 2015, 11:36 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125605/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 11:36 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> We handle screen add/remove, but not the active screen we're on changing size/position.
> 
> KScreen can potentially resize an existing screen after it detects one has been removed, also virtualbox can resize guest displays when the host resizes the window.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.cpp f5c22fc28032668a2ec033a9fb3a7c3e72dab925 
> 
> Diff: https://git.reviewboard.kde.org/r/125605/diff/
> 
> 
> Testing
> -------
> 
> Resized virtualbox client, lock screen remained usable.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151012/067b8d57/attachment.html>