Review Request 125605: Resize lock screen windows if screen size changes
Martin Gräßlin
mgraesslin at kde.org
Mon Oct 12 12:26:45 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125605/#review86708
-----------------------------------------------------------
ksmserver/screenlocker/greeter/greeterapp.cpp (line 259)
<https://git.reviewboard.kde.org/r/125605/#comment59676>
can we trust that QScreen or should we use the one of the view?
- Martin Gräßlin
On Oct. 12, 2015, 1:36 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125605/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2015, 1:36 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> We handle screen add/remove, but not the active screen we're on changing size/position.
>
> KScreen can potentially resize an existing screen after it detects one has been removed, also virtualbox can resize guest displays when the host resizes the window.
>
>
> Diffs
> -----
>
> ksmserver/screenlocker/greeter/greeterapp.cpp f5c22fc28032668a2ec033a9fb3a7c3e72dab925
>
> Diff: https://git.reviewboard.kde.org/r/125605/diff/
>
>
> Testing
> -------
>
> Resized virtualbox client, lock screen remained usable.
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151012/6afd9311/attachment.html>
More information about the Plasma-devel
mailing list