Review Request 125118: [Icon widget] support dropping onto folder

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125118/
-----------------------------------------------------------

(Updated Oct. 10, 2015, 11:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Bhushan Shah, Emmanuel Pescosta, and Eike Hein.


Changes
-------

Submitted with commit 7e3942abe3569fa08c0263c6164649029a9a068c by Kai Uwe Broulik to branch master.


Repository: plasma-workspace


Description
-------

This allows to drop file(s) onto a folder and have it ask whether to copy/move/link and brings up error dialogs if any.


Diffs
-----

  applets/icon/package/contents/ui/main.qml 49e91ca 
  applets/icon/plugin/icon_p.h 5b0f752 
  applets/icon/plugin/icon_p.cpp 97af67a 

Diff: https://git.reviewboard.kde.org/r/125118/diff/


Testing
-------

Dropping brings up the copy/move/paste dialog, copied, moved, and linked files, works. Confirmation dialogs are desktop modal. Also, I had to create my own QDropEvent from the declarative one.

Modifiers are broken but this is apparently a Qt bug, also I don't know whether my int cast to flags is right. Thanks Emmanuel for guiding me through this.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151010/6c027192/attachment.html>