Review Request 125089: Fix changing volume with horizontal scroll
Xuetian Weng
wengxt at gmail.com
Sat Oct 10 23:15:16 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125089/#review86652
-----------------------------------------------------------
I notice this part of code has that common problem on touchpad. Mind to implement samething like: https://git.reviewboard.kde.org/r/121346/ ? :)
- Xuetian Weng
On Sept. 7, 2015, 11:41 a.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125089/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2015, 11:41 a.m.)
>
>
> Review request for Plasma and Harald Sitter.
>
>
> Repository: plasma-pa
>
>
> Description
> -------
>
> Fix changing volume with horizontal scroll in applet compact representation.
>
> Horizontal scroll was only lowering the volume when scrolling to both directions.
>
>
> Diffs
> -----
>
> applet/contents/ui/main.qml e86ddae
>
> Diff: https://git.reviewboard.kde.org/r/125089/diff/
>
>
> Testing
> -------
>
> left/right scroll now lowers/raises volume.
>
> Actually, left scroll raises the volume and right scroll lowers it. But I get the same behavior as on Quick Controls Slider, so probably just bug with my mouse (or it's reversed in Qt).
>
>
> Thanks,
>
> David Rosca
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151010/345db73b/attachment.html>
More information about the Plasma-devel
mailing list