Review Request 125555: Port KAuth return code error checking in fontinst
Hrvoje Senjan
hrvoje.senjan at gmail.com
Fri Oct 9 23:56:37 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125555/#review86603
-----------------------------------------------------------
kcms/kfontinst/dbus/FontInst.cpp (line 958)
<https://git.reviewboard.kde.org/r/125555/#comment59612>
Shouldn't this be if (!j->exec()) { ?
- Hrvoje Senjan
On Oct. 8, 2015, 3:38 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125555/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2015, 3:38 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Someone whilst porting had simply commented it out
> This causes the install dialog to freeze if there's a problem.
>
> CCBUG: 344473
> CCBUG: 300951
> CCBUG: 345234
>
>
> Diffs
> -----
>
> kcms/kfontinst/dbus/FontInst.cpp 42413c1a05717f416681ef32317b8914c2ba35ec
>
> Diff: https://git.reviewboard.kde.org/r/125555/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151009/0fdeae0a/attachment-0001.html>
More information about the Plasma-devel
mailing list