Review Request 125568: Revised Breeze Plasma theme for 5.5.
Uri Herrera
uri_herrera at nitrux.in
Fri Oct 9 20:23:06 UTC 2015
> On Oct. 9, 2015, 10:51 a.m., Marco Martin wrote:
> > I tried it but unfortunately I have several issues with it:
> > * the first one, that may have avoided all the others: I discovered the existence of this thing just now. the default plasma theme is the one thing that
> > I'm sorry this looks like a complete refusal of it :( but again all of those could have been avoided with a different workflow
> > * It doesn't use the stylesheets, colors can't be dynamically changed (of all the issues, I consider this one the absolute showstopper).
> > * there are embedded images that are used just as references (like in button) this makes the files heavier to load
> > * actionbuttons won't work that way, it will break all round buttons that aren't radio buttons (as the checkmark won't be rendered correctly as well)
> > * I really don't like shadows of one single pixel, especially in the panel/popups (while i don't like the plasma theme trying too hard to look like the desktop theme, the depth of the shadow was the one thing that should have been either consistent or even a bit more, as they are at an higher z-order than the other woindows)
> > * besides being one single pixel, the shadow is wrong at the corner, the background is one pixel rounded, while the inner part of the shadow is square, leaving an hole of one pixel at the corner. On high dpi displays that would become very visible
> > * I really, really dislike the taskbar, looks cluttered and somewhat "old"
>
> Marco Martin wrote:
> anyways, I think i'll try to write a simple script or app to batch convert monochrome icons to using stylesheets so even when icons from theme and from plasma are mixed the colors would be correct
>
> Marco Martin wrote:
> made a simple tool that applies the stylesheets to svgs replacing some colors that come from the breeze palette, may still need some adjustments but seems to work.
> it needs the "xmlstarlet" commandline tool that should be packaged in most distributions.
>
> Uri Herrera wrote:
> I was never fond of having a Plasma theme that looked like it's having it's own party and that the application windows were just invited to that party. Different colors, different buttons, different icons, different direction. It doesn't use stylesheets because here: base.kde.org/Development/Tutorials/Plasma/ThemeDetails that's not mentioned, not once, not a reference and so I don't know how do they work, what each value applies to and playing the guessing game it's not fun. So I went with what I know and what I could figure out on my own. The embedded bitmaps are just leftovers that I haven't removed. I used the plasmoids that are installed by default to test the theme and I haven't found one that uses actionbuttons, the checkmark in itself was wrong it was a tick when it's a square in the widget style it doesn't make sense to me that it's different and it's being rendered inside a button too. I didn't see either a plasmoid that uses the radio buttons. Using heavy shadows is fine for application windows, it's visually fine, but widgets are not applications and it's not appealing to have them use a heavier shadow than the applications.
>
> The taskmanager was absolutely confusing to me the way it is and it was the second thing I changed after the icons.
>
> Marco Martin wrote:
> i guess the plasmoids with not much shadow can make sense, i would really like more shadow on panel and popups tough since they go over the windows (and a quite pedestrian practical reason, i want to keep it quite visible as is done in a complicate way passing it to kwin and we are porting the mechanism to wayland, if it becomes almost invisible it may well break without us noticing in the ongoing heavy refactoring)
Ok cool I'll increase the shadow of the panel; by popups you mean the tooltips and notifications?.
- Uri
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125568/#review86532
-----------------------------------------------------------
On Oct. 9, 2015, 8:18 p.m., Uri Herrera wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125568/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 8:18 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> SVG elements done from scratch, reused only a small portion of the existing files. Colors now match Breeze colorscheme. Buttons now match widget style. Icons in the system tray are taken from the icon theme. Icons in Kickoff are not monochromatic as only 16px and 22px icons are monochrome in Breeze. Better padding overall for elements. New visual for both task manager widgets that matches the states of the buttons. Checkboxes, radio buttons, sliders and scrollbars now have the colors used in the Breeze colorscheme.
>
>
> Diffs
> -----
>
>
> Diff: https://git.reviewboard.kde.org/r/125568/diff/
>
>
> Testing
> -------
>
> 
> 
>
> 
> 
>
>
> Thanks,
>
> Uri Herrera
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151009/fe23e7b2/attachment.html>
More information about the Plasma-devel
mailing list