Review Request 125006: Add individual monitor for each cpu option for system load viewer

Kåre Särs kare.sars at iki.fi
Fri Oct 9 13:07:25 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125006/
-----------------------------------------------------------

(Updated Oct. 9, 2015, 1:07 p.m.)


Review request for Plasma, David Edmundson, Dominik Haumann, and Martin Yrjölä.


Changes
-------

-Use units.gridUnit in stead of pixels
-propert if () {}
-Add preffered sizes so that the layouts look good without restarting
-Add a custom tool-tip widget if there are more than 6 cpus (the standard tooltip text is restricted to lines)
-Uncheck "cpus separately" if cpu monitor is unchecked


Repository: kdeplasma-addons


Description
-------

When compact-bar monitos are selected the "show: CPUs separately" is enabled. When activated every cpu gets it's own monitor. The individual monitors try to fit in the space of two bars but when the number of cpus are too high the widht of the cpu monitors grow proportionally.


Diffs (updated)
-----

  applets/systemloadviewer/package/contents/config/main.xml 0edfd89 
  applets/systemloadviewer/package/contents/ui/GeneralSettings.qml a577b1a 
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 8023b44 

Diff: https://git.reviewboard.kde.org/r/125006/diff/


Testing (updated)
-------

Running it on my own computer ;)


Thanks,

Kåre Särs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151009/11fc52ff/attachment.html>


More information about the Plasma-devel mailing list