Review Request 125562: Default for look and feel of applets, take 2

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125562/#review86537
-----------------------------------------------------------



shell/shellcorona.cpp (line 1036)
<https://git.reviewboard.kde.org/r/125562/#comment59588>

    If this is like an qmlengine, making an scriptengine is going to be heavy, can we reshuffle this code to be after we load the test if the file exists.



shell/shellcorona.cpp (line 1064)
<https://git.reviewboard.kde.org/r/125562/#comment59589>

    this is going to happen every time a containment is restored as well as actually created?


- David Edmundson


On Oct. 9, 2015, 11:08 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125562/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 11:08 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> (draft) mutually exclusive with https://git.reviewboard.kde.org/r/125558/
> a bit more flexible
> different approach: execute a script from the look and feel package when an applet is added, adding to the script environment "applet" that wraps the currently added applet and "containment" that wraps its containment.
> from there the javascript part can do anything it can do in the startup script as well.
> Still missing, something similar will have to be executed when a new containment is added as well.
> 
> 
> Diffs
> -----
> 
>   shell/packageplugins/lookandfeel/lookandfeel.cpp a6cef04 
>   shell/shellcorona.cpp 37d0534 
> 
> Diff: https://git.reviewboard.kde.org/r/125562/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151009/057a0e7e/attachment.html>