Review Request 125558: Allow look and feel packages to specify default configs for applets

[Marco Martin]

> On Oct. 8, 2015, 4:07 p.m., Eike Hein wrote:
> > Maybe we should do <packagename>/defaultrc?
> > 
> > Should we use scripting instead to allow computed defaults?
> > 
> > Do we somehow need to allow different defaults depending on containment or does that make no sense?
> 
> Marco Martin wrote:
>     a defaults config file already exist, i could merge it with this one, but i tought it's easier to have them separed if distributions want to customize only plasmoids and not the rest (like ksplash theme) that they would have to copy over the default file.
>     
>     about using scripting, it could be useful to manage more complicated scenarios, but I wouldn't know how to do it, as that place in containmentprivate is the only safe place to poke with the configuration, since is te exact spot in which the applet has been created, it already has an id, but the configuration hasn't been read yet and the kconfigskeleton hasn't been created yet, and being in plasma-framework I can't use scripting there, as is all in plasmashell.
>     
>     to use scripting i would have to execute it way after from plasmashell, so the applet would be created with the default configuration that would then be overwritten with the applet then reacting at the change (perhaps in some cases could even be visible in the ui the applet adapting itself)
>     it would be a bit messier, even tough possible.. so that largely depends how much is needed scripting.
>     like, how much conditional config values that can be reliably computed only there are needed
> 
> Eike Hein wrote:
>     > a defaults config file already exist, i could merge it with this one, but i tought it's easier to have them separed if distributions want to customize only plasmoids and not the rest (like ksplash theme) that they would have to copy over the default file.
>     
>     Right, I thought separation would be nicer too, that's why I pondered namespacing by package folder ... :)

alternative with scripting, https://git.reviewboard.kde.org/r/125562/
(i like that i have to tamper less with plasma-framework in that case)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125558/#review86512
-----------------------------------------------------------


On Oct. 8, 2015, 3:54 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125558/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 3:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> with this patch (and a small adaption in plasma-workspace) if the look and feel package contains a file called "defaultappletconfig" with a form like
> 
> [Applets][org.kde.plasma.analogclock]
> showSecondHand=true
> 
> all newly created applets, from either the widget explorer or the scripting shell will have such configuration, in the example all analog clocks would have the seconds hand shown by default.
> present applets configured differently are not affected
> 
> 
> Diffs
> -----
> 
>   src/plasma/corona.h 36ae60b 
>   src/plasma/corona.cpp f8d5c7d 
>   src/plasma/private/containment_p.cpp 3836772 
>   src/plasma/private/corona_p.h 2ee13a5 
> 
> Diff: https://git.reviewboard.kde.org/r/125558/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151008/1ae03230/attachment-0001.html>