Review Request 125545: Don't start an eventLoop from QML in menu entry editing

[Eike Hein]

> On Oct. 8, 2015, 3:44 p.m., Eike Hein wrote:
> > Ship It!

Looks good, thanks!


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125545/#review86510
-----------------------------------------------------------


On Oct. 7, 2015, 9:49 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125545/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2015, 9:49 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> From the docs:
> This is dangerous, because when an event loop is entered in a signal
> handler or binding, the QML engine continues to run other bindings,
> animations, transitions, etc. Those bindings can then cause side effects
> which, for example, destroy the hierarchy containing your event loop.
> 
> There was a queuedConnection approach that I guess tries to supress the problem, but it clearly didn't work.
> In any case, it's better not to freeze the shell
> 
> BUG: 347997
> 
> 
> Diffs
> -----
> 
>   applets/kicker/plugin/appentry.cpp 45644d4f8b8b4e83debb90e9acaf52db14ead7ec 
>   applets/kicker/plugin/menuentryeditor.cpp ce202c7ae6540bc7f4e3da53211d224dd9eedce7 
> 
> Diff: https://git.reviewboard.kde.org/r/125545/diff/
> 
> 
> Testing
> -------
> 
> Edited an app fine.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151008/aebf9451/attachment.html>