Review Request 125552: [server] Add support for flags on transient ShellSurfaceInterface

Martin Gräßlin mgraesslin at kde.org
Thu Oct 8 08:45:55 UTC 2015



> On Okt. 8, 2015, 10:39 vorm., Thomas Lübking wrote:
> > src/server/shell_interface.h, line 224
> > <https://git.reviewboard.kde.org/r/125552/diff/1/?file=410245#file410245line224>
> >
> >     Is this feature actually limited to transients?

in wl_shell_surface it seems to be limited to transients and popups - they are the only calls taking the additional flags in their calls. I do not know how it's for xdg_shell.

For what is worth: output only windows can be achieved by setting an input mask on the Surface.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125552/#review86481
-----------------------------------------------------------


On Okt. 8, 2015, 10:25 vorm., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125552/
> -----------------------------------------------------------
> 
> (Updated Okt. 8, 2015, 10:25 vorm.)
> 
> 
> Review request for kwin, Plasma, Marco Martin, and Sebastian Kügler.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> A transient surface can indicate through the flags that it does not
> want to accept keyboard focus. This is now exposed through a dedicated
> method.
> 
> 
> Diffs
> -----
> 
>   autotests/client/test_wayland_shell.cpp d4cdde52c9de185b0539e28951d39a42b39bcd50 
>   src/server/shell_interface.h 2bf0a61d3b59898a593fc63a4a4311ddd5534a85 
>   src/server/shell_interface.cpp 17656f1de20d0904823aa2089f1cbdf318585afc 
> 
> Diff: https://git.reviewboard.kde.org/r/125552/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151008/118d4532/attachment-0001.html>


More information about the Plasma-devel mailing list