Review Request 125433: kcm_kamera: Double calls to load() lead to strange scrollbars after saving a change

[Christian Butcher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125433/
-----------------------------------------------------------

(Updated Oct. 8, 2015, 8:04 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Graphics, Plasma and Marcus Meissner.


Changes
-------

Submitted with commit 67f21dab67409261879268c6372b69ad95eb9e74 by Christian Butcher to branch master.


Repository: kamera


Description
-------

The displayGPSuccessDialogue(void) function calls load() as its last statement currently.

Documentation for the KCModule api (both [kde4](http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKCModule.html) and [frameworks](http://api.kde.org/frameworks-api/frameworks5-apidocs/kconfigwidgets/html/classKCModule.html)) informs the reader that load() is called at the end of construction - consequently it seems that the additional load() call leads to the function (which is implemented as KKameraConfig::load() ) being called twice.

[Bug 236844](https://bugs.kde.org/show_bug.cgi?id=236844) may be related but at least on my KF5 based system, this does not cause or prevent a crash, which is referenced in the bug.

Separately, COPYING-CMAKE-SCRIPTS is referenced by the FindGphoto2.cmake file, and seems to have missed the commit in [RR-125230](https://git.reviewboard.kde.org/r/125230/). If this was intentional, then my apologies for readding here, but if so, the FindGphoto2.cmake file will need changing in some way.


Diffs
-----

  COPYING-CMAKE-SCRIPTS PRE-CREATION 
  kcontrol/kamera.cpp 2d8f61449a5a6f2650d864c864652ebea780a422 
  kcontrol/kameradevice.h b0ecb974f8fcb765228afe1965aeebab8e7656ed 

Diff: https://git.reviewboard.kde.org/r/125433/diff/


Testing
-------

When the call is present, opening the Kamera KCM within systemsettings after saving changes and going back to the main systemsettings view leads to a strange set of scrollbars.

With the additional call removed, the KCM-Kamera opens properly on the second attempt, after saving changes.

As a camera to test, the first (in the scroll list) serial port camera is 'Achiever Digital Adc65'. 'Barbie' may be easier to find as the first entry for 'B', and is also more memorable... I used a serial camera, since then the kcm will load images even without a camera connected


File Attachments
----------------

scrollbars
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/28/74e8bd93-4c4a-4103-9fb1-7bd106258058__kcm1.png
Settings panel
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/1cc9a8bc-b8a9-40d4-986d-3ae91d040d17__Screenshot_20151008_164010.png
Information panel
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/13129de5-a4f3-4bd8-958b-205505a9d973__info.png
Test panel
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/176fcc11-c56a-4782-a827-88c0b0b75347__test.png
Config panel
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/08/afae96ce-7281-42b6-aaac-dc8b8299eb30__configure.png


Thanks,

Christian Butcher

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151008/7592b846/attachment-0001.html>