Review Request 125546: xcb cursor: Add support for Qt::BlankCursor

[Thomas Lübking]

> On Okt. 8, 2015, 7:05 vorm., Martin Gräßlin wrote:
> > Maybe I'm missing something, but shouldn't a blank cursor result in no cursor being set?
> 
> Thomas Lübking wrote:
>     "XCB_CW_CURSOR
>     If a cursor is specified, it will be used whenever the pointer is in the window. If None is speci- fied, the parent’s cursor will be used when the pointer is in the window, and any change in the parent’s cursor will cause an immediate change in the displayed cursor."
>     
>     Usually one would hide the cursor (like eg. the zoom effect does) but hide/show needs a global counter (and does not apply to certain windows)
> 
> Martin Gräßlin wrote:
>     > Usually one would hide the cursor (like eg. the zoom effect does) but hide/show needs a global counte
>     
>     sounds like the right solution here. As git grep "Qt::BlankCursor":
>     
>     effects/flipswitch/flipswitch.cpp:            effects->startMouseInterception(this, Qt::BlankCursor);
>     effects/flipswitch/flipswitch.cpp:            effects->startMouseInterception(this, Qt::BlankCursor);
>     
>     So Flipswitch should be changed to hide/show the cursor like zoom effect does?

"could" - If it doesn't need another shape ever.

Ideally we'd provide that in effects::startMouseInterception(), but this starts to become a problem once the effect wants to update the shape later on.

General support for "blank per window" might be desirable, though (some tabboxes w/o mouse support?)

What does coverswitch do btw? Should be pretty much the same?


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125546/#review86468
-----------------------------------------------------------


On Okt. 7, 2015, 4:25 nachm., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125546/
> -----------------------------------------------------------
> 
> (Updated Okt. 7, 2015, 4:25 nachm.)
> 
> 
> Review request for kwin, Plasma and Martin Gräßlin.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> Add support for Qt::BlankCursor, used eg. in FlipSwitch effect.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 44a423c 
>   cursor.cpp 880f46b 
>   kcmkwin/kwinrules/CMakeLists.txt f4e2271 
> 
> Diff: https://git.reviewboard.kde.org/r/125546/diff/
> 
> 
> Testing
> -------
> 
> Qt::BlankCursor now correctly sets empty cursor
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151008/2cb37827/attachment.html>