Review Request 125546: xcb cursor: Add support for Qt::BlankCursor

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125546/#review86453
-----------------------------------------------------------



cursor.cpp (line 344)
<https://git.reviewboard.kde.org/r/125546/#comment59566>

    try
    uint8_t cur_blank_bits[32] = {0x00};
    
    (shorter, and you don't have to count 0x00's ;-)



cursor.cpp (line 363)
<https://git.reviewboard.kde.org/r/125546/#comment59565>

    this belongs into ::createCursor and I suggest to not operate on an empty string, but name it "blank" or "empty" (also see ::cursorName())


- Thomas Lübking


On Okt. 7, 2015, 1:06 nachm., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125546/
> -----------------------------------------------------------
> 
> (Updated Okt. 7, 2015, 1:06 nachm.)
> 
> 
> Review request for kwin, Plasma and Martin Gräßlin.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> Add support for Qt::BlankCursor, used eg. in FlipSwitch effect.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 44a423c 
>   cursor.cpp 880f46b 
>   kcmkwin/kwinrules/CMakeLists.txt f4e2271 
> 
> Diff: https://git.reviewboard.kde.org/r/125546/diff/
> 
> 
> Testing
> -------
> 
> Qt::BlankCursor now correctly sets empty cursor
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151007/3635d772/attachment.html>