Review Request 125528: Check for nullptr screen

[David Edmundson]

> On Oct. 5, 2015, 1:59 p.m., David Edmundson wrote:
> > src/plasmaquick/dialog.cpp, line 156
> > <https://git.reviewboard.kde.org/r/125528/diff/1/?file=409731#file409731line156>
> >
> >     just QGuiApplication::screens() should be fine here.
> 
> Christoph Cullmann wrote:
>     Hmm, is then there not a regression that we look at screens not in the right "group"? At least I understood the docs that way that you don't get just all screens with virtualSiblings, but I am no expert.

theoretically there's a difference, yes:

(in X terms) An output's siblings will all be on the screen and you can have multiple screens.
You'd use the latter for pre-xinerama multihead. 

tbh I'd be super surprised if that still actually worked.

However, all we're doing is querying if a screen contains a point and that should be the same.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125528/#review86371
-----------------------------------------------------------


On Oct. 5, 2015, 1:41 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125528/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 1:41 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Bugs: 345173
>     http://bugs.kde.org/show_bug.cgi?id=345173
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Check for nullptr screen
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp 8d4f508 
> 
> Diff: https://git.reviewboard.kde.org/r/125528/diff/
> 
> 
> Testing
> -------
> 
> As Qt was stupid enough to change the API, we now need to check for nullptr.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151005/bea7f60a/attachment.html>