Review Request 125528: Check for nullptr screen

David Edmundson david at davidedmundson.co.uk
Mon Oct 5 13:59:08 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125528/#review86371
-----------------------------------------------------------


Thanks for looking into this.


src/plasmaquick/dialog.cpp (line 156)
<https://git.reviewboard.kde.org/r/125528/#comment59491>

    just QGuiApplication::screens() should be fine here.


- David Edmundson


On Oct. 5, 2015, 1:41 p.m., Christoph Cullmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125528/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2015, 1:41 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Bugs: 345173
>     http://bugs.kde.org/show_bug.cgi?id=345173
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Check for nullptr screen
> 
> 
> Diffs
> -----
> 
>   src/plasmaquick/dialog.cpp 8d4f508 
> 
> Diff: https://git.reviewboard.kde.org/r/125528/diff/
> 
> 
> Testing
> -------
> 
> As Qt was stupid enough to change the API, we now need to check for nullptr.
> 
> 
> Thanks,
> 
> Christoph Cullmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151005/6e4631b1/attachment.html>


More information about the Plasma-devel mailing list