Review Request 125443: Make tooltip dialog hidden on the cursor entering the inactive ToolTipArea
David Edmundson
david at davidedmundson.co.uk
Fri Oct 2 11:16:45 UTC 2015
> On Oct. 2, 2015, 10:56 a.m., Takahiro Hashimoto wrote:
> > How about updated pacth?
Ever so sorry, I didn't see you updated this :S
Looks perfect.
Thanks for reminding me.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125443/#review86219
-----------------------------------------------------------
On Sept. 30, 2015, 1:48 a.m., Takahiro Hashimoto wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125443/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 1:48 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Now PlasmaCore.ToolTipArea can control status of active/inactive.
>
> When a ToolTip dialog is visible and making mouse move to another inactive ToolTipArea, it remains unnaturally for a while.
>
>
> I attached a urgy test program to reproduce this behavior. The instruction to reproduce is:
>
> 1.run qmlscene tooltip_hide.qml
> 2. make mouse cursor on the cell named "name1" (or any odd numbered one)
> 3. move the cursor to a even numberd cell like "name2"
>
> It results the "tip1" tooltip remains for a long time (current spec is 4000ms)
>
> I think it would be better when a mouse entered into an inatcive ToolTipArea, the global tooltip dialog is dismissed soon. This patch is the implementation of this behavior.
>
> I cannot check all side-effect to change this behavior. Many guys adivce are welcomed:)
>
> Here's my reference use case: https://git.reviewboard.kde.org/r/125402/
>
>
> Diffs
> -----
>
> src/declarativeimports/core/tooltip.cpp 3ffcdba
> tests/tooltip.qml b153188
>
> Diff: https://git.reviewboard.kde.org/r/125443/diff/
>
>
> Testing
> -------
>
> Apply patch and build and test on master.
>
> Tested with my test program attached this review request. Works fine to me.
>
>
> File Attachments
> ----------------
>
> test program
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/29/c1653f27-c5b2-46e4-85bb-69a9d02720c5__tooltip_hide.qml
> update current tooltip test program
> https://git.reviewboard.kde.org/media/uploaded/files/2015/09/30/2c2a8d31-c5ec-48ed-aeb1-90a2a67596f1__ss_tooltip_test.png
>
>
> Thanks,
>
> Takahiro Hashimoto
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151002/bccfef9b/attachment.html>
More information about the Plasma-devel
mailing list