Review Request 125376: KNotification: don't update notification twice

[Igor Poboiko]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125376/
-----------------------------------------------------------

(Updated Oct. 1, 2015, 2:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Martin Klapetek.


Changes
-------

Submitted with commit f47d59b8a03b74306af3ad490303a6ea70245350 by Igor Poboiko to branch master.


Repository: knotifications


Description
-------

I've noted a bug when using KDE Telepathy: if I receive 2 new messages, first creates a new notification, and second is being duplicated (see screenshot attached; on it I just wrote myself "hello", then "world").

Investigation showed following:
 * KTp calls KNotification::setText on existing notification
 * KNotification starts d->updateTimer, which will update notification in 100 msec
 * KTp call KNotification::sendEvent, which updates notification
 * updateTimer expires calling KNotification::update() again, leading to duplicated DBus message and duplicated notification

Not sure if there is any bug in BugZilla, but it is 100% reproducible in my case.


Diffs
-----

  src/knotification.cpp cf09e63 

Diff: https://git.reviewboard.kde.org/r/125376/diff/


Testing
-------

After applying patch it works fine.


File Attachments
----------------

The problem
  https://git.reviewboard.kde.org/media/uploaded/files/2015/09/24/161f9955-068a-4b39-85d0-8537b05d9cb2__snapshot22.png


Thanks,

Igor Poboiko

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151001/94caf3d7/attachment.html>