Review Request 126185: Make the KAppTemplate CMake module global

[Simon Wächter]

> On Nov. 27, 2015, 6:21 p.m., Simon Wächter wrote:
> > Thanks for moving the template macro to the ECM module. A few things I am not quite sure:
> > 
> > - Is the .kdev_ignore file still in use? I never saw it in a KDevelop project
> > - If you commit the patch, I'll delete the macro from KAppTemplate and move all templates to the specific projects
> > - I also should write a second macro, that tests the generated application - but since I started my Bachelor I completely run out off time :/
> 
> Marco Martin wrote:
>     the file is pushed.
>     about the .kdev_ignore file i'm not sure.. Aleix, do you know about that?
> 
> Marco Martin wrote:
>     I removed the plasmoid template from kapptemplate, as it would conflict with the one installed by plasma-framework during packaging
>     the cmake macro is still there (and they don't conflict as the macro name is different)

Ok thank you, I'll clean up KAppTemplate


- Simon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126185/#review88898
-----------------------------------------------------------


On Nov. 30, 2015, 2:47 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126185/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 2:47 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Simon Wächter.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> -------
> 
> templates are very useful as teaching tool in order to make
> a minimal application that uses a certain framework.
> templates in the KAppTemplate repository will always get forgotten
> (plus kapptemplate is not really necessary as they work in kdevelop as well)
> An ideal situation would be frameworks having templates in their own repos
> with templates of barebone apps using the main framework features.
> In order to do that, the cmake stuff needed in order to correctly install
> a template needs to be ported to a place avaiable to all frameworks
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDETemplateMacro.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126185/diff/
> 
> 
> Testing
> -------
> 
> done some templates installed by plasma-framework
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151130/bb670271/attachment-0001.html>