Review Request 126031: [appletinterface] Allow specifying separate toolTipIcon

[Marco Martin]

> On Nov. 11, 2015, 8:06 p.m., Kai Uwe Broulik wrote:
> > I like the applet previews in widget explorer but making them the actual applet icon was a not completely thought through. The tooltip icons are a mess now, Kickoff doesn't have the KDE logo anymore, not to mention the clocks. System Tray "More Entries" config icons are useless now (you can't tell anything at 16x16) etc. But I guess it's too late to fix that now..

Does the new approach for icon fix this? (widget explorer shows icons==plugin name, plasmoid.icon is still the old one, the undo notification may have to be modified to use plugin name as well)


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126031/#review88264
-----------------------------------------------------------


On Nov. 11, 2015, 7:39 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126031/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2015, 7:39 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> With the new applet icons it can be desireable to remove the tooltip icon. This is especially prominent with the clocks where the small icon shows a random date causing confusion.
> 
> Problem with Plasmoid.icon is that it also affects eg. the undo notification, unsetting it would show a KDE logo there.
> 
> 
> Diffs
> -----
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126031/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151130/a13df3a8/attachment.html>