Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

David Edmundson david at davidedmundson.co.uk
Mon Nov 30 09:57:58 UTC 2015



> On Nov. 29, 2015, 11:26 p.m., David Edmundson wrote:
> > shell/panelview.cpp, line 832
> > <https://git.reviewboard.kde.org/r/126175/diff/4/?file=419337#file419337line832>
> >
> >     why this instead of proxying the event like the others?
> 
> Anthony Fieroni wrote:
>     I don't understaind what you mean?
> 
> Anthony Fieroni wrote:
>     I use this patch since i made it, no problems at all.

I mean, why do you call setFocus rather than doing the same QCoreApplication::postEvent that the other mouse events do.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126175/#review88932
-----------------------------------------------------------


On Nov. 28, 2015, 3:30 a.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126175/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2015, 3:30 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Bugs: 354651
>     https://bugs.kde.org/show_bug.cgi?id=354651
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> You can see videos in bug repot
> 
> 
> Diffs
> -----
> 
>   shell/panelview.cpp 3407501 
> 
> Diff: https://git.reviewboard.kde.org/r/126175/diff/
> 
> 
> Testing
> -------
> 
> I test patch and all works as expected.
> http://doc.qt.io/qt-5/qevent.html
> QEvent::Leave	11	Mouse leaves widget's boundaries.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151130/f66c65dc/attachment.html>


More information about the Plasma-devel mailing list