Review Request 126205: If the user runs failsafe mode, use software rendering in QtQuick

Martin Gräßlin mgraesslin at kde.org
Mon Nov 30 09:55:36 UTC 2015



> On Nov. 30, 2015, 10:18 a.m., Martin Gräßlin wrote:
> > What does QT_XCB_FORCE_SOFTWARE_OPENGL?
> 
> David Edmundson wrote:
>     It makes Qt apps pretend LIBGL_ALWAYS_SOFTWARE is set.
> 
> Martin Gräßlin wrote:
>     Sorry, but that doesn't do what you hope it does:
>     
>     - only affects Mesa drivers
>     - if Mesa is broken for whatever reason the software rasterizer will also be broken
>     - kwin does something completely different with failsafe: no OpenGL at all.
>     
>     So if you get crashers due to e.g. broken NVIDIA driver, this won't fix it.
> 
> David Edmundson wrote:
>     Yeah, I knew it didn't fix nvidia. 
>     
>     I know it's not perfect, but I have seen user's on bugzilla with positive results from it, so when I saw this code block (whilst editing something else) it seemed like it might fix some situations, and I can't see any real downsides.

> I can't see any real downsides

the downside is that it switches to CPU rendering. Which seems not the best thing to do in general. I cannot imagine a situation where the actual mesa drivers are broken and llvmpipe wouldn't be broken, too. So I just don't see what this would improve for fail safe. I don't see a possible improvment, so for me the downside (CPU rendering) seems worse. Any pointers to bug reports where users had a broken mesa, but a still working llvmpipe can change my mind ;-)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126205/#review88943
-----------------------------------------------------------


On Nov. 30, 2015, 10:13 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126205/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 10:13 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Graphics seem more likely than anything else to be broken, if the user
> explicitly selects failsafe mode from the DM we should follow the same
> rationale as kwin and not trust the user's drivers.
> 
> 
> Diffs
> -----
> 
>   startkde/startkde.cmake 41a8975cce1fb2a4e7a034e697ce6e2cc59d5b1e 
> 
> Diff: https://git.reviewboard.kde.org/r/126205/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151130/8f563625/attachment-0001.html>


More information about the Plasma-devel mailing list