Review Request 126175: Click on item in plasmashell case focus stays on last pointed item

Anthony Fieroni bvbfan at abv.bg
Mon Nov 30 04:39:37 UTC 2015



> On Ноев. 30, 2015, 1:25 преди обяд, David Edmundson wrote:
> > >MoseMove is too expensive event to be redirect, it can cause problems on slow CPU's.
> > 
> > I don't see how. 
> > It's no different to when the mouse is actually over the containment.
> > 
> > The case for when you're in the 4px margin at the edge of the panel seems like it must be tiny.

First of all, you don't understaind the problem at all. Every postEvent is expensive, not for allocating memory, case event is append to queque. Here problem is simple - QEvent::Leave is append to queque *before* MouseMove, this behavior can be easy preproduce at slower CPU's like mine. To make redirect on evey mousemove is not only stupid, it's more expencive than any other event.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126175/#review88931
-----------------------------------------------------------


On Ноев. 28, 2015, 5:30 преди обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126175/
> -----------------------------------------------------------
> 
> (Updated Ноев. 28, 2015, 5:30 преди обяд)
> 
> 
> Review request for Plasma, David Edmundson and Marco Martin.
> 
> 
> Bugs: 354651
>     https://bugs.kde.org/show_bug.cgi?id=354651
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> You can see videos in bug repot
> 
> 
> Diffs
> -----
> 
>   shell/panelview.cpp 3407501 
> 
> Diff: https://git.reviewboard.kde.org/r/126175/diff/
> 
> 
> Testing
> -------
> 
> I test patch and all works as expected.
> http://doc.qt.io/qt-5/qevent.html
> QEvent::Leave	11	Mouse leaves widget's boundaries.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151130/d14a1f19/attachment.html>


More information about the Plasma-devel mailing list