[Breeze] [Bug 355906] Please consider unification for themes' data paths.

[Sebastian Kügler via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=355906

--- Comment #15 from Sebastian Kügler <sebas at kde.org> ---
You gave the answer yourself in the description, have another look at
https://github.com/tsujan/Kvantum/commit/17a41413263dc546fac816ae1eb43aceb6366eb4
.

If we added support for another path / directory scheme, we'd have to do these
things:

- change the lookup logic (from listing a directory to also looking into the
/usr/share/themes subdirectory you propose
- change the installation logic, adding installation to /usr/share/themes *and*
checking if a suitable candidate is already installed, overwriting or
overriding that one; for every single type of theme we use
- defining which one overrides which, so the lookup order matters here as well
(you can't just append the paths, because you want the more local lookups done
first (so the user can override system-installed themes)

This would duplicate all of the lookup logic, so the code in a whole number of
applications becomes more error-prone, costlier to maintain and slower. 

For performance, the bottom line is that even if we manage to look up themes
just as fast as we currently do in the new path (I doubt that's easily
possible), in order to remain backwards-compatible, we'd have to do that
additionally to the current mechanism. We're never going to be able to do less
or even the same amount of lookups, it will be at least twice the amount of
work to what we currently do.

-- 
You are receiving this mail because:
You are the assignee for the bug.