Review Request 126160: Wizard: Set minimum size of window to ensure entire PIN is visible

[David Rosca]

> On Nov. 25, 2015, 5:35 p.m., Martin Klapetek wrote:
> > As you don't implement your own sizeHint() in the wizard - can you be sure that QWizard::sizeHint() will always return sensible value?
> > 
> > As an alternative, you could just scale the font to always fit the wizard. That would also help with resizing the window (for whatever reason).

It does, it just ignores it if the sizeHint() was changed after initializePage(). Setting wizard sizepolicy to minimum has also no effect either.

That's why wizard->setMinimumSize(wizard->sizeHint()) in second diff works.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126160/#review88839
-----------------------------------------------------------


On Nov. 25, 2015, 5:03 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126160/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 5:03 p.m.)
> 
> 
> Review request for Plasma and Martin Klapetek.
> 
> 
> Bugs: 355798
>     https://bugs.kde.org/show_bug.cgi?id=355798
> 
> 
> Repository: bluedevil
> 
> 
> Description
> -------
> 
> Set the minimum window size to be twice the width of PIN label.
> 
> 
> Diffs
> -----
> 
>   src/wizard/pages/pairing.cpp 6d1eac0 
> 
> Diff: https://git.reviewboard.kde.org/r/126160/diff/
> 
> 
> Testing
> -------
> 
> The window gets resized now if there is not enough free space for PIN.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151125/2a120fbb/attachment.html>