Review Request 126165: quickshare: Trigger paste from clipboard action on click

[David Rosca]

> On Nov. 25, 2015, 2:12 p.m., Sebastian Kügler wrote:
> > Not so sure about this: Just clicking on it will publish information on an online service, that's hardly what a naive user would expect. On middle-click I think it would be fine, but a normal click is usually used to open some kind of popup, if we ship the clipboard to the internet in that case, we may be producing privacy leaks inadvertently.
> > 
> > If you make it paste only on pressing the middle button, I'd be OK with this.
> 
> Aleix Pol Gonzalez wrote:
>     Just clicking will show the dialog with alternatives.

It asks you first what to do and where to publish (in a popup), so no random uploads.

Originally, I made it on middle click, but then I changed it to just left click because it already pastes on left click when it gets uri from activity manager.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126165/#review88801
-----------------------------------------------------------


On Nov. 25, 2015, 1:32 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126165/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 1:32 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> It is now possible to paste with mouse click even when ContentTracker's uri is empty.
> 
> 
> Diffs
> -----
> 
>   applets/quickshare/plasmoid/contents/ui/main.qml 77bec00 
> 
> Diff: https://git.reviewboard.kde.org/r/126165/diff/
> 
> 
> Testing
> -------
> 
> Works fine, I no longer need to open context menu and select Paste.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151125/5b67824b/attachment.html>