Review Request 126159: [Containmentinterface] Don't offer to set a wallpaper for a panel

Kai Uwe Broulik kde at privat.broulik.de
Tue Nov 24 20:13:27 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126159/
-----------------------------------------------------------

(Updated Nov. 24, 2015, 8:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Changes
-------

Submitted with commit c7bfe07b1cb2973c863762e01d7144668b5d980b by Kai Uwe Broulik to branch master.


Repository: plasma-framework


Description
-------

Dropping an image on the desktop will ask whether we want to set it as a wallpaper. The same happens on a panel which makes no sense and does nothing. This removes the option.


Diffs
-----

  src/scriptengines/qml/plasmoid/containmentinterface.cpp 7632c40 

Diff: https://git.reviewboard.kde.org/r/126159/diff/


Testing
-------

Dropped jpeg onto my desktop -> it asked whether I wanted to create an icon or set as "Image" wallpaper
Dropped jpeg onto my panel -> it created an icon right away without asking


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151124/ec6718ad/attachment.html>


More information about the Plasma-devel mailing list