Review Request 126148: [plasma-framework] qstring optimizations

[Nick Shaforostoff]

> On Nov. 23, 2015, 9:02 p.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 122
> > <https://git.reviewboard.kde.org/r/126148/diff/1/?file=417949#file417949line122>
> >
> >     Why do you drop FAST_CONCATENATION?

ack QT_USE_FAST_CONCATENATION /usr/include/ brings nothing
ack QT_USE_QSTRINGBUILDER /usr/include/ brings real results


On Nov. 23, 2015, 9:02 p.m., Nick Shaforostoff wrote:
> > Regarding QStringLiteral vs QLatin1String for libraries: I read that thread, but then most of QStringLiterals here sould be dropped as well if that was the case. I don't think it makes sense to make a special case of QIcon::fromTheme.

all qstringliteral uses except loadpackage() do not store strings in the static containers, i believe. for loadpackage calls i have removed qstringliterals in favour of qlatin1string


- Nick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126148/#review88735
-----------------------------------------------------------


On Nov. 23, 2015, 10:19 p.m., Nick Shaforostoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126148/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 10:19 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Martin Klapetek.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> also contains fix for clazy warning regarding iterating over temporary roleNames() object
> 
> note that for QRegExp constructor and for QIcon::fromTheme() i used QLatin1String because QStringLiteral is known to produce crashes-on-exit if the code is inside a library
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 812dc96 
>   src/declarativeimports/core/datamodel.cpp 1c83bc5 
>   src/declarativeimports/core/framesvgitem.cpp 9aab228 
>   src/declarativeimports/core/iconitem.cpp f32b3d1 
>   src/plasma/applet.cpp 895555c 
>   src/plasma/containment.cpp 1d166f2 
>   src/plasma/framesvg.cpp f9379b0 
>   src/plasma/pluginloader.cpp bfa5dee 
>   src/plasma/private/applet_p.cpp e935d52 
>   src/plasma/private/containment_p.cpp 3836772 
>   src/plasma/private/theme_p.cpp 7bf81d4 
>   src/plasma/scripting/scriptengine.cpp 5b2cf84 
>   src/plasma/svg.cpp 20cb31f 
>   src/plasma/theme.cpp c49ad4c 
>   src/plasmaquick/appletquickitem.cpp efe8611 
>   src/plasmaquick/shellpluginloader.cpp 2824760 
> 
> Diff: https://git.reviewboard.kde.org/r/126148/diff/
> 
> 
> Testing
> -------
> 
> compiles fine
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151123/07100f45/attachment.html>