Review Request 126148: [plasma-framework] qstring optimizations

[Nick Shaforostoff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126148/
-----------------------------------------------------------

(Updated Nov. 23, 2015, 10:19 p.m.)


Review request for Plasma, Marco Martin and Martin Klapetek.


Changes
-------

removed QStringLiteral use for LoadPackage calls becaus they may store the string argument in the static variable


Repository: plasma-framework


Description
-------

also contains fix for clazy warning regarding iterating over temporary roleNames() object

note that for QRegExp constructor and for QIcon::fromTheme() i used QLatin1String because QStringLiteral is known to produce crashes-on-exit if the code is inside a library


Diffs (updated)
-----

  CMakeLists.txt 812dc96 
  src/declarativeimports/core/datamodel.cpp 1c83bc5 
  src/declarativeimports/core/framesvgitem.cpp 9aab228 
  src/declarativeimports/core/iconitem.cpp f32b3d1 
  src/plasma/applet.cpp 895555c 
  src/plasma/containment.cpp 1d166f2 
  src/plasma/framesvg.cpp f9379b0 
  src/plasma/pluginloader.cpp bfa5dee 
  src/plasma/private/applet_p.cpp e935d52 
  src/plasma/private/containment_p.cpp 3836772 
  src/plasma/private/theme_p.cpp 7bf81d4 
  src/plasma/scripting/scriptengine.cpp 5b2cf84 
  src/plasma/svg.cpp 20cb31f 
  src/plasma/theme.cpp c49ad4c 
  src/plasmaquick/appletquickitem.cpp efe8611 
  src/plasmaquick/shellpluginloader.cpp 2824760 

Diff: https://git.reviewboard.kde.org/r/126148/diff/


Testing
-------

compiles fine


Thanks,

Nick Shaforostoff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151123/e2c10a4b/attachment.html>