Review Request 125993: Implemented lastfmimagefetcher as a Plugin

[Aditya Dev Sharma]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
-----------------------------------------------------------

(Updated Nov. 22, 2015, 2:19 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Changes
-------

Minor changes in coding style


Repository: plasma-mediacenter


Description
-------

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList. Created a QList for storing the new media.

After the image is fetched, gotImage emits the signal imageFetched (from mediaLibrary) with the QList we created earlier. This signal is absorbed by handleNewMedia in PmcMetaDataModel which does the rest.


Diffs (updated)
-----

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
-------

Builds 100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this. 
Also, I get the following Output : http://ix.io/mps
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151122/44ea4b2c/attachment-0001.html>